Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix flaky chart interval test #146667

Merged
merged 4 commits into from
Nov 30, 2022
Merged

[Discover] Fix flaky chart interval test #146667

merged 4 commits into from
Nov 30, 2022

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Nov 30, 2022 •
edited
Loading

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.6.0 labels Nov 30, 2022
@jughosta jughosta self-assigned this Nov 30, 2022
@jughosta jughosta mentioned this pull request Nov 30, 2022
Closed
@jughosta jughosta linked an issue Nov 30, 2022 that may be closed by this pull request
Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group1/_discover·ts - discover/group1 discover test query should show correct initial chart interval of Auto #146223
Closed
@jughosta jughosta marked this pull request as ready for review November 30, 2022 11:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

davismcphee
davismcphee approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks for fixing! Only thing I'm curious about is why we're merging directly to 8.6 instead of backporting. Do we not need this in main?

@jughosta
Copy link
Contributor Author

@davismcphee It did not fail on main and was skipped only for 8.6.

@jughosta jughosta merged commit ae979de into elastic:8.6 Nov 30, 2022
@jughosta jughosta deleted the 146223-flaky-test branch November 30, 2022 16:26
@davismcphee
Copy link
Contributor

@davismcphee It did not fail on main and was skipped only for 8.6.

That's true, and I guess we can't really unskip a test in main that was never skipped. I just assume that means we'd also be at risk for it failing on main since it contains the 8.6 changes, but not this fix. I'm not sure what our process is supposed to be here though, so for now I guess we'll see if the issue persists in main and fix it separately there if it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

Assignees

@jughosta jughosta

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.6.0
Projects
None yet
Milestone
No milestone
4 participants
@jughosta @elasticmachine @kibana-ci @davismcphee